Rename BinaryOperator to InfixOperator.. #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Often when I want to start something new, like handling the kinds of "no-meaning" operators, I find there is some code that is imprecise or weak in some way that impacts doing the new thing well. One cool thing that we are in a position to do now (but isn't done in this PR) is to automatically fill in (or adjust) all of the operator symbols in the operator classes based on JSON data from MathicsScanner. The no-meaning-operators-from-JSON branch does this just. However, here I think it best to complete this, then the "no-meaning" branch, and then come back and do the rest of the operators. |
since that is more precisely what it is. Also, order functions inside builtin more alphabetically within each category of classes. Attach "ABC" to some abstract classes.
rocky
force-pushed
the
BinaryOperator-to-InfixOperator
branch
from
43ea355 to
9628da6
Compare
|
LGTM |
|
Thanks - onward and upward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename BinaryOperator to InfixOperator, since that is more precisely what it is.
Also, order functions inside builtin more alphabetically within each category of classes. Attach ABC to some abstract classes.