Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few small changes - #1113

Merged
merged 2 commits into from
Oct 2, 2024
Merged

A few small changes - #1113

merged 2 commits into from
Oct 2, 2024

Conversation

rocky
Copy link
Member

@rocky rocky commented Oct 1, 2024

Note API incompatibilty introduced in Pattern changes Adjust pattern comment
Remove Lint warning on compilation box

@@ -1,41 +0,0 @@
name: Mathics3 (OSX)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did this go away?

Copy link
Member Author

@rocky rocky Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - I forgot to add macos.yml. It should be added now.

OSX is a name that I suspect few use nowadays, macos is the commonly used name for the OS.

Note API incompatibilty introduced in Pattern changes
Adjust pattern comment
Remove Lint warning on compilation box
@rocky rocky force-pushed the misc-fixes branch 2 times, most recently from 83d8c8f to fa2c682 Compare October 1, 2024 14:47
Copy link
Contributor

@mmatera mmatera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rocky rocky merged commit e3a2e86 into master Oct 2, 2024
11 checks passed
@rocky rocky deleted the misc-fixes branch October 2, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants