ReadList[] refactor
#1093
Merged
ReadList[] refactor
#1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What remains is updating pytests and doctests. I will be doing that next. But this is getting rather large so we should consider merging and iterating. |
rocky
changed the title
ReadList[] refactor
|
@rocky, thanks for the work. When you feel it is ready, let's merge and iterate. |
start to handle TokenWords. Add more systemsymbols, and add a proper error message for TokenWorken option processing
and move parse Read ReadList options to eval.
Move options parsing code from builtin to eval. (It is not used yet though Isolate eval code from Read.eval to eval_Read
Correct return type when Read or ReadList file is not found. ReadList[..., Word] needs to also consider internally default record separators Add ReadList sample data
rocky
force-pushed
the
file_io_read-refactor
branch
from
af371ab to
2a042f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move builtin/read.py -> eval/files_io/read.py and start to handle TokenWords.
Add more systemsymbols,
Add a proper error message for TokenWord option processing
I come at this in trying to get lisp.mathics working.