Test b64 #1061
Merged
Test b64 #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squelch some some lint messages in numbers.py
Merged
rocky
added a commit
that referenced
this pull request
Aug 8, 2024
Looking at #1061 I realized we could not change `$CharacterEncoding` from inside the session. This PR makes the behavior of this symbol closer to the one in WMA. --------- Co-authored-by: rocky <[email protected]>
|
LGTM. Do have any idea why your previous comment mentioned something about the test being conditional, but here it is in unconditionally? |
|
Probably because when it was a doctest the output was dependent on the encoding and the platform. Now it seems it is not a problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore an old doctest in the form of a pytest