Skip to content

Commit

Permalink
A few small changes -
Browse files Browse the repository at this point in the history
Note API incompatibilty introduced in Pattern changes
Adjust pattern comment
Remove Lint warning on compilation box
  • Loading branch information
rocky committed Oct 1, 2024
1 parent 1ee6520 commit b01df45
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/osx.yml → .github/workflows/macos.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Mathics3 (OSX)
name: Mathics3 (macOS)

on:
push:
Expand Down
7 changes: 7 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,13 @@ Performance

* ``Blank*`` patterns without arguments are now singletons.

API Incompatibility
-------------

* ``Matcher`` now requires an additional ``evaluation`` parameter




7.0.0
-----
Expand Down
5 changes: 3 additions & 2 deletions mathics/builtin/box/compilation.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,12 @@
"""
Boxing Symbols for compiled code
"""
# Docs are not yet ready for prime time. Maybe after release 6.0.0.
no_doc = True

from mathics.builtin.box.expression import BoxExpression

# Docs are not yet ready for prime time. Maybe after release 6.0.0.
no_doc = True


class CompiledCodeBox(BoxExpression):
"""
Expand Down
4 changes: 1 addition & 3 deletions mathics/core/pattern.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,7 @@ class BasePattern(ABC):

expr: BaseElement

# this attribute allows for a faster match algorithm based on sameq.
# Probably we should split ExpressionPattern into two different classes,
# one for literal patterns and the other for "Regular" ExpressionPatterns.
# This attribute facilitates a faster match algorithm based on sameQ.
isliteral: bool = False

# TODO: In WMA, when a BasePattern is created, the attributes
Expand Down

0 comments on commit b01df45

Please sign in to comment.