Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added svm scratch code #24

Merged
merged 2 commits into from
Oct 16, 2022
Merged

Added svm scratch code #24

merged 2 commits into from
Oct 16, 2022

Conversation

vandit98
Copy link
Contributor

@vandit98 vandit98 commented Oct 16, 2022

fixes #issue_number (if any, otherwise delete this line)

link for issue

Description

I have added scratch code for linear regression and support vector machine.

Type of change

Note: Please delete options that are not relevant.

  • Added code for new algorithm

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mayureshagashe2105 mayureshagashe2105 self-requested a review October 16, 2022 08:28
@Math-behind-AI Math-behind-AI deleted a comment from HemanthSai7 Oct 16, 2022
Copy link
Member

@mayureshagashe2105 mayureshagashe2105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Also, move your linear_regression.ipynb file to the existing LinearRegression directory.
  • Your linear_regression.ipynb has some rendering errors in the last section for visualization of theta, loss function and gradient, please fix it.
  • Feel free to update the existing README and add the accuracy results for your algorithm.

@mayureshagashe2105 mayureshagashe2105 added documentation Improvements or additions to documentation enhancement New feature or request hacktoberfest hacktoberfest label for contributors labels Oct 16, 2022
@vandit98
Copy link
Contributor Author

hi
I have removed the linear regression code.

Copy link
Member

@mayureshagashe2105 mayureshagashe2105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging!

@mayureshagashe2105 mayureshagashe2105 merged commit aa5c3e2 into Math-behind-AI:main Oct 16, 2022
@mayureshagashe2105 mayureshagashe2105 changed the title Added linear regression and svm scratch code Added svm scratch code Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request hacktoberfest hacktoberfest label for contributors hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants