-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slurm and QResources updates #38
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #38 +/- ##
===========================================
+ Coverage 62.39% 63.16% +0.76%
===========================================
Files 15 15
Lines 1117 1143 +26
Branches 216 222 +6
===========================================
+ Hits 697 722 +25
Misses 418 418
- Partials 2 3 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Just a few typos (missing ".") and maybe add a test for _convert_qresources of shellio ? (+ also one question regarding the slurm states mapping, if you are clear about it, it's fine to me, otherwise, maybe put some comment about these two slurm states)
Co-authored-by: David Waroquiers <[email protected]>
Co-authored-by: David Waroquiers <[email protected]>
Co-authored-by: David Waroquiers <[email protected]>
This PR introduces the option to have an "empty"
QRsources
. Nowprocess_placement
can beNone
, representing a case of an empty set of resources, where no value should be set.Also added all the possible states for SLURM to address issue #37.