Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests #29

Merged
merged 18 commits into from
Jan 25, 2024
Merged

Unit tests #29

merged 18 commits into from
Jan 25, 2024

Conversation

davidwaroquiers
Copy link
Member

Adding unit tests for all functionalities.

… any complex

patterns in qtoolkit... And in any case, get_identifiers is only there
because it's not part of the standard library for python < 3.11.
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #29 (10b8838) into develop (c15463a) will increase coverage by 18.91%.
Report is 2 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop      #29       +/-   ##
============================================
+ Coverage    43.52%   62.43%   +18.91%     
============================================
  Files           15       15               
  Lines         1119     1118        -1     
  Branches       221      216        -5     
============================================
+ Hits           487      698      +211     
+ Misses         604      418      -186     
+ Partials        28        2       -26     
Files Coverage Δ
src/qtoolkit/core/data_objects.py 100.00% <ø> (+15.24%) ⬆️
src/qtoolkit/io/base.py 83.33% <100.00%> (+10.91%) ⬆️
src/qtoolkit/io/shell.py 100.00% <ø> (+21.00%) ⬆️
src/qtoolkit/io/slurm.py 77.31% <100.00%> (+55.17%) ⬆️

... and 3 files with indirect coverage changes

@davidwaroquiers davidwaroquiers changed the title [WIP]: Unit tests Unit tests Nov 16, 2023
@davidwaroquiers davidwaroquiers marked this pull request as ready for review November 16, 2023 12:20
@gpetretto gpetretto merged commit f960941 into develop Jan 25, 2024
6 checks passed
@ml-evs ml-evs deleted the unit_tests branch February 5, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants