-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow list of jobs from scheduler using username #187
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #187 +/- ##
===========================================
+ Coverage 47.89% 47.92% +0.03%
===========================================
Files 43 43
Lines 5153 5156 +3
Branches 1117 1118 +1
===========================================
+ Hits 2468 2471 +3
Misses 2425 2425
Partials 260 260
|
Thanks @gpetretto This option could also enable a "global" max number of jobs per user on a worker right ? (we already talked about such an option as it is sometimes a constraint in some supercomputers). |
This sounds very good to me. I guess we simply have to test it how (in)convenient it will be in the end and take adjustments accordingly 😃 |
that would be very useful for our clusters (that run with slurm) as well |
Indeed it could be a step in that direction. However, the logic of the Runner is still to check only the processes corresponding to that worker, while the count of processes running on a specific runner comes from the DB. So more changes and possibly more options in the configuration will be needed to provide that functionality. |
Sure, I wasn't suggesting to do it now but basically, we need this option before being able to possibly think about implementing/adding this feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Good to me, just one comment/question
09c3efd
to
e5e922f
Compare
Some schedulers (e.g. SGE) do not allow fetching job details providing a list of job ids, which is how jobflow-remote usually gets information about the running jobs. See Matgenix/qtoolkit#43. To avoid this issue an option to use the username as filtering option has been added. If it is present, the runner will use that instead of the list of ids.
@QuantumChemist, do you think this will be fine for your use case?