Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[copy_from] Proper cancelation via CancelOneshotIngestion message #31136

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[copy_from] Proper cancelation via CancelOneshotIngestion message #31136

wants to merge 1 commit into from
+251 −76

Conversation

ParkMyCar
Copy link
Member

This PR fixes the TODO(cf1) related to canceling oneshot ingestions. It adds a StorageCommand::CancelOneshotIngestion that reduces/compacts away a corresponding StorageCommand::RunOneshotIngestion, much like ComputeCommand::Peek and ComputeCommand::CancelPeek.

We send a StorageCommand::CancelOneshotIngestion whenever a user has canceled a COPY FROM statement, but also the storage controller will send one whenever a RunOneshotIngestion command completes.

Motivation

Fix TODO(cf1) related to cancelation

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@ParkMyCar ParkMyCar requested a review from teskje January 22, 2025 03:49
@ParkMyCar ParkMyCar requested review from a team as code owners January 22, 2025 03:49
@ParkMyCar ParkMyCar requested a review from aljoscha January 22, 2025 03:49
@ParkMyCar
start, proper cancelation for Oneshot Ingestions
68b82bd 
* add CancelOneshotIngestion message to the storage controller
* handle new message in 'reduce' and 'reconcile' in the storage-controller
* emit a CancelOntshotIngestion whenever an ingestion completes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teskje teskje Awaiting requested review from teskje

@aljoscha aljoscha Awaiting requested review from aljoscha aljoscha is a code owner automatically assigned from MaterializeInc/adapter

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ParkMyCar