-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vector based on lgalloc for flat container #27880
base: main
Are you sure you want to change the base?
Conversation
aa63bb2
to
60c7e2d
Compare
d5a39fb
to
08111dd
Compare
c249582
to
b685d5e
Compare
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
Signed-off-by: Moritz Hoffmann <[email protected]>
This PR introduces a small performance regression, which can be explained (in the future prevented.) At the moment, we're using vectors to store on dataflow edges, which have the nice property that they can be preallocated to a specific capacity. This concept doesn't (yet) exist in flat containers. Ideally, we'd like to preallocate each region to its desired size, but without knowing the actual data, we cannot know the size of the regions. The performance regression only affects the introspection dataflows, and seems to be in the range of 1-2%. A potential way forward is to introduce a |
Introduce containers that allow flat container regions to spill to disk.
Depends on:
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.