Skip to content

Commit

Permalink
storage: don't require backward compat for parameters.proto
Browse files Browse the repository at this point in the history
The protobuf types in this file are only used in the storage protocol
and never used across Mz versions.
  • Loading branch information
teskje committed Jan 21, 2025
1 parent 6cfbf9b commit 4348ff6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 9 deletions.
4 changes: 2 additions & 2 deletions src/buf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ breaking:
- storage-types/src/connections/aws.proto
# reason: currently does not require backward-compatibility
- storage-types/src/connections/string_or_secret.proto
# reason: remove after the commit that introduced it gets merged
- storage-types/src/errors.proto
# reason: currently does not require backward-compatibility
- storage-types/src/parameters.proto
lint:
use:
- DEFAULT
Expand Down
9 changes: 2 additions & 7 deletions src/storage-types/src/parameters.proto
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0.

// buf breaking: ignore (does currently not require backward-compatibility)

syntax = "proto3";

package mz_storage_types.parameters;
Expand All @@ -18,7 +20,6 @@ import "service/src/params.proto";
import "tracing/src/params.proto";

message ProtoStorageParameters {
reserved 1, 2, 3, 25, 12, 16, 26, 31, 39;
uint64 keep_n_source_status_history_entries = 4;
mz_rocksdb_types.config.ProtoRocksDbTuningParameters upsert_rocksdb_tuning_config = 5;
bool finalize_shards = 6;
Expand All @@ -28,7 +29,6 @@ message ProtoStorageParameters {
ProtoStorageMaxInflightBytesConfig storage_dataflow_max_inflight_bytes_config = 10;
mz_service.params.ProtoGrpcClientParameters grpc_client = 11;
uint64 shrink_upsert_unused_buffers_by_ratio = 13;
reserved 14, 15;
mz_proto.ProtoDuration pg_source_snapshot_statement_timeout = 17;
bool record_namespaced_errors = 18;
uint64 keep_n_privatelink_status_history_entries = 19;
Expand All @@ -49,9 +49,6 @@ message ProtoStorageParameters {
mz_proto.ProtoDuration replica_status_history_retention_window = 40;

mz_dyncfg.ConfigUpdates dyncfg_updates = 30;

reserved 27;
reserved "enable_dependency_read_hold_asserts";
}

message ProtoPgSourceSnapshotConfig {
Expand All @@ -67,7 +64,6 @@ message ProtoMySqlSourceTimeouts {
}

message ProtoKafkaTimeouts {
reserved 6;
bool keepalive = 1;
mz_proto.ProtoDuration socket_timeout = 2;
mz_proto.ProtoDuration transaction_timeout = 5;
Expand All @@ -87,7 +83,6 @@ message ProtoUpsertAutoSpillConfig {
}

message ProtoStorageMaxInflightBytesConfig {
reserved 2, 3, 5;
optional uint64 max_in_flight_bytes_default = 1;
bool disk_only = 4;
optional double max_in_flight_bytes_cluster_size_fraction = 6;
Expand Down

0 comments on commit 4348ff6

Please sign in to comment.