Dev #34
Open
Dev #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pressing 'Download Results' button in ui results view downloads the current results into a 'queryset' directory with images and a json. Implements core functionality in new utilities.data module
The 'Download Results' method in the results UI now also downloads subfigure label, and scale bar information, recreating a near complete recreation of original exsclaim jsons (unassasigned fields are not in the database). The download is down as a separate process and user can now specify results location.
Nature's HTML format changed, removing the tag with metadata we used to get the number of pages and results. Now this is retrieved from numbers displayed to users.
Renames and reformats journalfamily subclass attributes to be more intuitive. Implements method to obtain many search urls (varying date range, journal, and ordering method) to allow greater than 1000 results for acs and nature.
- class Wiley(JournalFamily) added - get_search_query_urls - class JournalFamily params
1. removed the text in "" for teh pub_type param 2. added in journal_list param that was missing 3. ACS --> Wiley in coment
Journal specific code should stay abstracted from the base class. Wiley year parameter is strange but can still fit same pattern of date_range_param=start<sep>end if we see <sep> as &BeforeYear= rather than the usual -
Changes made to add the Wiley publication family to the tool
Replaced: uses: pre-commit/[email protected] With: uses: pre-commit/[email protected]
update GitHub Actions workflow to use Node.js 16
Javascript fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.