Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMA-91 rest api should return 400 when data is invalid #81

Merged

Conversation

markpernia
Copy link
Collaborator

request with invalid data now returns 400

image

request without or expired token returns 401

image

expired token : eyJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJtYXRlai5mcm5rYUBnbWFpbC5jb20iLCJpYXQiOjE3MTA1ODE5NjIsImV4cCI6MTcxMDY2ODM2Mn0.WzjH3zjuNSoVbN-9iN1PwuH1FwvH8no5oxhdOvfgJKw

image

request to random URL returns 404

image

and finally with valid data

image

@@ -139,6 +139,22 @@ function HostEventComponent() {
toggle()
}

// retrieving users rank
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was removed from here in SMA-106 because isUserInRank is not parameter of JoinEventComponent anymore (JEC now handles retrieving user's rank)

@markpernia markpernia force-pushed the SMA-91-Rest-api-should-return-400-when-data-is-invalid branch from 7ef960e to 18e8cd1 Compare April 23, 2024 18:16
@markpernia markpernia merged commit 73ad94f into develop Apr 23, 2024
6 checks passed
@markpernia markpernia deleted the SMA-91-Rest-api-should-return-400-when-data-is-invalid branch April 23, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants