-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SMA-91 rest api should return 400 when data is invalid #81
Merged
markpernia
merged 15 commits into
develop
from
SMA-91-Rest-api-should-return-400-when-data-is-invalid
Apr 23, 2024
Merged
SMA-91 rest api should return 400 when data is invalid #81
markpernia
merged 15 commits into
develop
from
SMA-91-Rest-api-should-return-400-when-data-is-invalid
Apr 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johna91
approved these changes
Apr 22, 2024
MatejFrnka
approved these changes
Apr 23, 2024
MatejFrnka
approved these changes
Apr 23, 2024
ivamach
reviewed
Apr 23, 2024
@@ -139,6 +139,22 @@ function HostEventComponent() { | |||
toggle() | |||
} | |||
|
|||
// retrieving users rank |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was removed from here in SMA-106 because isUserInRank is not parameter of JoinEventComponent anymore (JEC now handles retrieving user's rank)
markpernia
force-pushed
the
SMA-91-Rest-api-should-return-400-when-data-is-invalid
branch
from
April 23, 2024 18:16
7ef960e
to
18e8cd1
Compare
markpernia
deleted the
SMA-91-Rest-api-should-return-400-when-data-is-invalid
branch
April 23, 2024 18:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
request with invalid data now returns 400
request without or expired token returns 401
expired token : eyJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJtYXRlai5mcm5rYUBnbWFpbC5jb20iLCJpYXQiOjE3MTA1ODE5NjIsImV4cCI6MTcxMDY2ODM2Mn0.WzjH3zjuNSoVbN-9iN1PwuH1FwvH8no5oxhdOvfgJKw
request to random URL returns 404
and finally with valid data