Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMA-82 unify font sizes #74

Merged
merged 14 commits into from
Apr 16, 2024
Merged

SMA-82 unify font sizes #74

merged 14 commits into from
Apr 16, 2024

Conversation

markpernia
Copy link
Collaborator

now all font sizes could be change in App.css

  /* font-sizes */
  --sm-h1-heading: 3em;
  --sm-text-content: 1em;
  --sm-text-medium-content: 1.2em; 

Unified font sizes across different pages. However, with the changes in size, some elements didn't look right, so I had to make adjustments to the alignment and positioning of other elements.

Additionally, the changes affects the dates in the Event component and the UpcomingEvent component due to the length of the string. because of that, I implemented formatting for the dates in the EventDTO object from an array of numbers to a string, which affect task SMA-93 I believe this also resolves the related bug.

I've commented out this part in Match.tsx which formats the array of numbers to a date, just in case it's necessary to revert back from a string to an array of numbers.

  const eventDate = new Date(
     parseInt(event.dateStart[0]),
     parseInt(event.dateStart[1]),
     parseInt(event.dateStart[2]),
   )

  const eventStartTime = () => {
     const hour = event.dateStart[3]
     const min = event.dateStart[4] === '0' ? '00' : event.dateStart[4]
     return hour + ':' + (min.length === 1 ? min + '0' : min)
   }
   const eventEndTime = () => {
     const hour = event.dateEnd[3]
     const min = event.dateEnd[4] === '0' ? '00' : event.dateEnd[4]
     return hour + ':' + (min.length === 1 ? min + '0' : min)
   }

@markpernia markpernia merged commit 3372bc2 into develop Apr 16, 2024
6 checks passed
@markpernia markpernia deleted the SMA-82-Unify-font-sizes branch April 16, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants