SMA-80: allow logging in and signing up with expired jwt token #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johna91
approved these changes
Apr 13, 2024
ivamach
changed the title
…th-expired-jwt-token
markpernia
approved these changes
Apr 13, 2024
ivamach
changed the title
MatejFrnka
requested changes
Apr 14, 2024
| try { | ||
| userEmail = jwtService.extractUserName(jwt); | ||
| } catch (Exception e) { | ||
| response.setStatus(HttpStatus.UNAUTHORIZED.value()); |
There was a problem hiding this comment.
Does this let you see public endpoints when you have invalid token?
I think it may be better to simply not add anything to the user context (instead of returning 401) and thus still allowing access to public endpoints.
MatejFrnka
deleted the
SMA-80-Allow-logging-in-and-signing-up-with-expired-jwt-token
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Navbar changed the code to delete token from local storage if the HTML error code is 401 or 403
In PrivateRoute used the same code, instead of checking if there is a token in the local storage.