Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMA-87-Add Annotation to the Pageable object #64

Merged
merged 8 commits into from
Apr 13, 2024
Merged

SMA-87-Add Annotation to the Pageable object #64

merged 8 commits into from
Apr 13, 2024

Conversation

kz44
Copy link
Collaborator

@kz44 kz44 commented Apr 9, 2024

Add the following annotation to endpoints using Pageable:

@ParameterObject

MatejFrnka
MatejFrnka requested changes Apr 10, 2024
View reviewed changes
Copy link
Owner

@MatejFrnka MatejFrnka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check it works with the frontend? While working on my tasks, I found that adding parameter object changes the frontend client a little bit.

Please go to the frontend and run npm run generate and push that code as well.

kz44 added 7 commits April 13, 2024 09:54
@kz44
feat: npm run generate
87b41b1
@kz44
Merge branch 'develop' of https://github.com/MatejFrnka/sportsmatch i…
a813cd2 
…nto SMA-87-Add-Annotation-to-the-Pageable-object

# Conflicts:
#	backend/sportsmatch/src/main/java/com/sportsmatch/controllers/EventsController.java
#	frontend/sportsmatch-app/src/generated/api/services/EventsControllerService.ts
@kz44
feat: removed redundant lines
d2b4c80
@kz44
feat: conflicts solved
ab36976
@kz44
feat: removed pageable
271f275
@kz44
feat: conflicts solved
1c2082c
@kz44
feat: correct error
991435b
@MatejFrnka MatejFrnka merged commit 36e0a0c into develop Apr 13, 2024
6 checks passed
@MatejFrnka MatejFrnka deleted the SMA-87-Add-Annotation-to-the-Pageable-object branch April 13, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markpernia markpernia markpernia approved these changes

@ivamach ivamach ivamach approved these changes

@Johna91 Johna91 Johna91 approved these changes

@MatejFrnka MatejFrnka MatejFrnka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kz44 @MatejFrnka @Johna91 @ivamach @markpernia