Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: SMA-26-Implement-the-main-page-design #30

Closed
wants to merge 6 commits into from

Conversation

DeakCsaba0124
Copy link
Collaborator

No description provided.

markpernia
markpernia previously approved these changes Feb 11, 2024
Copy link
Owner

@MatejFrnka MatejFrnka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main purpouse of components is to create reusable code, try to remake the search bar to be usable in other places as well.

I it really nice that you are making the page responsive, however, I would do the tasks from the most important to the least important. Right now, we need to get the frontend to exist :D, then we need to connect it with the backend and only after that we should focus on responsive design.

Try to get the design to look good on mobile, don't worry too much about the desktop view for now

}
}

return (
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is needed, just reuse the SportsButtonComponent

<div className="components-container">
<MainPageSliderComponent />
<MainPageSearchBarComponent />
<MainPageSportsBtnComponent />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use sportsButtonComponent intead

import '../styles/MainPage.css'
import { FaSearchLocation } from 'react-icons/fa'

function MainPageSearchBarComponent() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just call this Search Bar component to show that it can be used anywhere, not just on the main page

position: relative;
}

.slide img {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slide should be in css of the slide component so that it can exist independently of the main page component

outline-color: #e85f29;
}

.search-container-btn {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for the search bar

@MatejFrnka MatejFrnka changed the title SMA-26-Implement-the-main-page-design WIP: SMA-26-Implement-the-main-page-design Feb 20, 2024
@MatejFrnka MatejFrnka closed this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants