-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: SMA-26-Implement-the-main-page-design #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main purpouse of components is to create reusable code, try to remake the search bar to be usable in other places as well.
I it really nice that you are making the page responsive, however, I would do the tasks from the most important to the least important. Right now, we need to get the frontend to exist :D, then we need to connect it with the backend and only after that we should focus on responsive design.
Try to get the design to look good on mobile, don't worry too much about the desktop view for now
} | ||
} | ||
|
||
return ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is needed, just reuse the SportsButtonComponent
<div className="components-container"> | ||
<MainPageSliderComponent /> | ||
<MainPageSearchBarComponent /> | ||
<MainPageSportsBtnComponent /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use sportsButtonComponent intead
import '../styles/MainPage.css' | ||
import { FaSearchLocation } from 'react-icons/fa' | ||
|
||
function MainPageSearchBarComponent() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just call this Search Bar component to show that it can be used anywhere, not just on the main page
position: relative; | ||
} | ||
|
||
.slide img { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slide should be in css of the slide component so that it can exist independently of the main page component
outline-color: #e85f29; | ||
} | ||
|
||
.search-container-btn { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same for the search bar
…ons with css files'
No description provided.