SMA-32: Implement upcoming match and match in progress #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivamach
previously approved these changes
Feb 2, 2024
MatejFrnka
requested changes
Feb 2, 2024
| } | ||
|
|
||
| .host .row { | ||
| margin: 0.75em 0; |
There was a problem hiding this comment.
If I am not mistaken, MatchInProgress and upcoming are almost the same. I would use just one CSS to avoid duplicated code
| </a> | ||
| <h1> | ||
| Matchmaking | ||
| <br /> in progress |
There was a problem hiding this comment.
I would use just one component for both match in progress and upcoming match - they are almost the same, we are running into danger of having them inconsistent after some time if we keep them separate. We can discuss on saturday
MatejFrnka
previously approved these changes
Feb 3, 2024
markpernia
dismissed
MatejFrnka’s stale review
The merge-base changed after approval.
MatejFrnka
previously approved these changes
Feb 3, 2024
MatejFrnka
dismissed
their stale review
The merge-base changed after approval.
MatejFrnka
approved these changes
Feb 3, 2024
ivamach
approved these changes
Feb 3, 2024
markpernia
deleted the
SMA-32-Implement-upcoming-match-match-in-progress
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.