Sma 21 add endpoint that returns all sports #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatejFrnka
previously approved these changes
Jan 27, 2024
| * @return paginated list of SportDTO | ||
| */ | ||
| @GetMapping("/all") | ||
| public List<SportDTO> getSports(final Pageable pageable) { |
There was a problem hiding this comment.
I realised that we might not need pagination for sports because there will probably only be at most 50 different sports. But lets keep it for now as an example
There was a problem hiding this comment.
I miss understood it sorry. I thought later there will be someting filter for it too like search in it or something like that
ivamach
previously approved these changes
Jan 27, 2024
Johna91
previously approved these changes
Jan 27, 2024
…nto SMA-21_Add_endpoint_that_returns_all_sports # Conflicts: # backend/sportsmatch/src/main/java/com/sportsmatch/repositories/SportRepository.java
kz44
dismissed stale reviews from Johna91, ivamach, and MatejFrnka
via
651f561
…nto SMA-21_Add_endpoint_that_returns_all_sports
…nto SMA-21_Add_endpoint_that_returns_all_sports
markpernia
previously approved these changes
Feb 1, 2024
ivamach
approved these changes
Feb 1, 2024
markpernia
approved these changes
Feb 1, 2024
MatejFrnka
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: Add endpoint that returns all sports
Description: