Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add counting sort in the list of sorting techniques #113

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

kratik1237
Copy link

Description

Add counting sort in the list of sorting techniques

Issue number

#14

Issue fixes: #14
Screenshot (70)
Screenshot (71)

Copy link

vercel bot commented Jul 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visual-sort ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 7:37am

@kratik1237
Copy link
Author

pls review the PR #113 for the issue #14 @MastanSayyad

@MastanSayyad MastanSayyad added VSoC’24 Contribution under VSoC'24 BONUS issue is very hard labels Jul 16, 2024
@MastanSayyad
Copy link
Owner

@kratik1237 The page has so many bugs

@MastanSayyad
Copy link
Owner

MastanSayyad commented Jul 16, 2024

The PR is incomplete:

  • The footer is not matching to website design theme it is not aligned
  • The navbar is not same as home page, especially the dropdown
  • The page is not responsive
  • You didn't add counting sort card in sorting visluzier section also you didn't create a visualizer in visual.html
  • You didn't add section for counting sort in algotthms section with its working gif and pesudo code
  • You didn't integrated scroll to top button and AI chatbot like other sorting pages!

@kratik1237

@kratik1237
Copy link
Author

@MastanSayyad i can fix it wait.

@MastanSayyad
Copy link
Owner

Fix it in other PR @kratik1237

@MastanSayyad
Copy link
Owner

MastanSayyad commented Jul 16, 2024

I will merge this for now, i will 35 bonus points for this and 40 bonus points for other PR

@kratik1237
Copy link
Author

kratik1237 commented Jul 16, 2024

Okay ,but it is my last pr for visual sort @MastanSayyad

@MastanSayyad
Copy link
Owner

MastanSayyad commented Jul 16, 2024

I will merge this for now, make another PR, if this one is your last PR then I can add 50 points only if you are okay with it then fix it in This PR @kratik1237

@kratik1237
Copy link
Author

kratik1237 commented Jul 16, 2024

Are you going to create a new pr or fixing in this one? @kratik1237

@kratik1237
Copy link
Author

yes @MastanSayyad

@MastanSayyad MastanSayyad merged commit 3a55fcb into MastanSayyad:main Jul 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BONUS issue is very hard VSoC’24 Contribution under VSoC'24
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add counting sort in the list of sorting techniques
4 participants