Fixes related to bsky.social migration #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This points the firehose consumer to bsky.network, and checks for messages with empty blocks, preventing errors when one appears.
|
Thank you for your effort! I have a plan also to bring cursor migration with URI changes. Could you bring it with this PR pls? Idk something like if there is a cursor already in DB and it wasn't dropped let's drop it first and save the new one |
|
Something like this? Might be a bit overkill, but allows for further migrations if requred |
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR points the firehose consumer to
bsky.networkuntil the SDK is updated to include it as the new default (closes #4), and includes a fix from the SDK repo to ignore messages with empty blocks that get consumed for whatever reason.I'm sure these particular fixes will make their way into the SDK at some point, but this will get feeds going until then! 😊