Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to send aspect ratio with send_video #521

Merged
merged 9 commits into from
Jan 21, 2025

Conversation

yamamotura
Copy link
Contributor

@yamamotura yamamotura commented Jan 21, 2025

Small adjustment so that both client and it's example support setting aspect ratio

@yamamotura
Copy link
Contributor Author

Ah right - might wanna edit:

Add image aspect ratio to prevent default 1:1 aspect ratio

to

Add video aspect ratio to prevent default 1:1 aspect ratio

@MarshalX
Copy link
Owner

hi and thank you for your contribution! do not worry about titles and commit messages; could you please update async client as well? we have code generator for it;

please fix ruff:

image

@yamamotura
Copy link
Contributor Author

should be good

@MarshalX MarshalX changed the title Video aspect ratio Add ability to send aspect ratio with send_video Jan 21, 2025
@MarshalX MarshalX merged commit 58afe81 into MarshalX:main Jan 21, 2025
23 checks passed
@MarshalX
Copy link
Owner

amazing! thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants