Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar in the README #492

Merged
merged 5 commits into from
Dec 15, 2024
Merged

Fix grammar in the README #492

merged 5 commits into from
Dec 15, 2024

Conversation

ErikPohl444
Copy link
Contributor

@ErikPohl444 ErikPohl444 commented Dec 13, 2024

Fixed some grammar in the readme. Closes #483

Fixed some grammar in the readme
Copy link
Owner

@MarshalX MarshalX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you please review the entire README and fix the English? Also, I want to mention, we have 2 copies of the readme. One for GitHub and another one for the docs website. You should update this file as well: https://github.com/MarshalX/atproto/blob/main/docs/source/readme.content.md

@ErikPohl444
Copy link
Contributor Author

Hello! Glad to help. I'll first align my current changes into:
https://github.com/MarshalX/atproto/blob/main/docs/source/readme.content.md

Then I'll read and revise as needed, submitting changes across both.

BTW: This is an excellent README overall, and one which got me started quickly. The descriptive nature and word-choices are great. I'd be honored to contribute little edits here and there when recommended.

Thank you.

@MarshalX MarshalX changed the title Update README.md Fix grammar in the README Dec 14, 2024
Made additional language changes per request.
@ErikPohl444
Copy link
Contributor Author

Reviewed and synched changes between readmes.

@MarshalX
Copy link
Owner

MarshalX commented Dec 14, 2024

@ErikPohl444 thank you! I synced changes between readmes in the single Pull Request. Pls check. All good?

@ErikPohl444
Copy link
Contributor Author

All good. Thank you!

@MarshalX MarshalX merged commit 4332cf5 into MarshalX:main Dec 15, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

would like to contribute a change to the readme
2 participants