Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#6 Add an endpoint for deleting logs of an execution #36

Merged
merged 1 commit into from
Feb 19, 2024
Merged

#6 Add an endpoint for deleting logs of an execution #36

merged 1 commit into from
Feb 19, 2024

Conversation

remi-picard
Copy link

Implementing #6

image

@remi-picard remi-picard changed the title #6 Add an endpoint for deleting logs of an execution Add an endpoint for deleting logs of an execution #6 Jan 21, 2024
@remi-picard remi-picard changed the title Add an endpoint for deleting logs of an execution #6 #6 Add an endpoint for deleting logs of an execution Jan 21, 2024
Noordsestern
Noordsestern approved these changes Feb 18, 2024
View reviewed changes
Copy link
Member

@Noordsestern Noordsestern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remi-picard could you resolve the conflict with main branch? It's probably easy, but since the changes on main are yours, too, I do not like to risk resolving the conflict in the wrong way myself 😬

@Noordsestern Noordsestern self-assigned this Feb 18, 2024
@remi-picard
Copy link
Author

LGTM

@remi-picard could you resolve the conflict with main branch? It's probably easy, but since the changes on main are yours, too, I do not like to risk resolving the conflict in the wrong way myself 😬

I have just rebased my branch onto the main branch and resolve the conflict.

@Noordsestern
Copy link
Member

Noordsestern commented Feb 18, 2024 •
edited
Loading

One conflict is left in tests/test_app.py... oh, i see! that was the other PR is just merged. Can you fix it again? Sorry 😬

@remi-picard
Copy link
Author

One conflict is left in tests/test_app.py... oh, i see! that was the other PR is just merged. Can you fix it again? Sorry 😬

fixed

@Noordsestern Noordsestern merged commit b0d571a into MarketSquare:master Feb 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noordsestern Noordsestern Noordsestern approved these changes

Assignees

@Noordsestern Noordsestern

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remi-picard @Noordsestern