Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules no-global-variable, no-suite-variable, and no-test-variable #1137

Merged
merged 19 commits into from
Nov 3, 2024

Conversation

Lakitna
Copy link
Contributor

@Lakitna Lakitna commented Oct 30, 2024

Closes #1117

I'm not 100% sure about the tone of voice for the docs 🤔

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.92%. Comparing base (f62508c) to head (4fdbdf8).
Report is 43 commits behind head on master.

Files with missing lines Patch % Lines
robocop/checkers/misc.py 97.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1137      +/-   ##
==========================================
- Coverage   97.02%   96.92%   -0.10%     
==========================================
  Files          37       39       +2     
  Lines        4670     5014     +344     
==========================================
+ Hits         4531     4860     +329     
- Misses        139      154      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

robocop/checkers/misc.py Outdated Show resolved Hide resolved
robocop/checkers/misc.py Outdated Show resolved Hide resolved
robocop/checkers/misc.py Outdated Show resolved Hide resolved
robocop/checkers/misc.py Outdated Show resolved Hide resolved
robocop/checkers/misc.py Outdated Show resolved Hide resolved
@bhirsz
Copy link
Member

bhirsz commented Nov 1, 2024

Thanks for the PR, look good enough! The tone in the docs looks fine, though I'm not best doc writer .. :) If needed we can always improve it over time. I have left some comments but it's mostly nitpicks or improvements ideas (some stuff I've noticed I could also do with my rules, it's easier to see it if I look into someone else code).

@Lakitna
Copy link
Contributor Author

Lakitna commented Nov 2, 2024

Those where some good suggestions :)

I think I covered them all

@Lakitna Lakitna requested a review from bhirsz November 2, 2024 11:26
@bhirsz bhirsz merged commit 0da243b into MarketSquare:master Nov 3, 2024
12 checks passed
@Lakitna Lakitna deleted the rule/no-non-local-variable branch November 4, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Rule] No test variable, no suite variable, and no global variable
2 participants