-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rules no-global-variable
, no-suite-variable
, and no-test-variable
#1137
Rules no-global-variable
, no-suite-variable
, and no-test-variable
#1137
Conversation
…cal-variable # Conflicts: # robocop/checkers/community_rules/keywords.py # robocop/checkers/misc.py
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1137 +/- ##
==========================================
- Coverage 97.02% 96.92% -0.10%
==========================================
Files 37 39 +2
Lines 4670 5014 +344
==========================================
+ Hits 4531 4860 +329
- Misses 139 154 +15 ☔ View full report in Codecov by Sentry. |
Thanks for the PR, look good enough! The tone in the docs looks fine, though I'm not best doc writer .. :) If needed we can always improve it over time. I have left some comments but it's mostly nitpicks or improvements ideas (some stuff I've noticed I could also do with my rules, it's easier to see it if I look into someone else code). |
Those where some good suggestions :) I think I covered them all |
Closes #1117
I'm not 100% sure about the tone of voice for the docs 🤔