Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix acceptance tests with latest flask and werkzeug #391

Merged

Conversation

PaulBrandUWV
Copy link
Contributor

Fix acceptance tests with latest flask and werkzeug.
The local test http server based on flask and werkzeug was not working with the latest versions. This PR fixes that.

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.06%. Comparing base (533c31c) to head (9ad22d5).
Report is 5 commits behind head on master.

❗ Current head 9ad22d5 differs from pull request most recent head e5d0561. Consider uploading reports for the commit e5d0561 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #391      +/-   ##
==========================================
+ Coverage   86.00%   86.06%   +0.06%     
==========================================
  Files           9        9              
  Lines         450      452       +2     
  Branches      108      108              
==========================================
+ Hits          387      389       +2     
  Misses         57       57              
  Partials        6        6              
Flag Coverage Δ
acceptance 82.30% <ø> (+0.31%) ⬆️
unit 59.73% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucagiove
Copy link
Member

So this will work only for later python versions?

@PaulBrandUWV
Copy link
Contributor Author

So this will work only for later python versions?

It's no so much related to the python version. This works with werkzeug version 3 and up. Before is werkzeug 2.x was used.

@lucagiove lucagiove added the bug label May 6, 2024
@lucagiove lucagiove added this to the 1.0 milestone May 6, 2024
@lucagiove lucagiove merged commit f2b4270 into MarketSquare:master May 6, 2024
6 checks passed
@PaulBrandUWV PaulBrandUWV deleted the fix_latest_flask_werkzeug branch June 2, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants