Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update german, some additional translations. This is nearly the remaining part. #747

Merged
merged 23 commits into from
May 31, 2024

Conversation

peter-pri
Copy link
Contributor

No description provided.

@i-make-robots
Copy link
Contributor

I would love to come up with a strategy that would make it easier for you to complete translations. Any ideas?

@peter-pri
Copy link
Contributor Author

peter-pri commented May 29, 2024

My strategies so far have been:

  1. Check every menu entry in the user interface manually if a German text appears or the the symbolic key name.
  2. Check the results of automated tests, which translations are missing.

Results until now: All translations tests are passed.
One translation is missing in my last change:
Converter_CMYK_Crosshatch.Note

Initially I had a typo in there, so I removed it to get it working.

It would be helpful if the english.xml file has the same formatting as the other languages.
This can be easily done e.g. with the vscode extension XML Tools form Josh Johnson.
In addition the file content should be sorted alphabetically by the keys to make it comparable with a Linux tool like meld.
With this sorting task I was not successful until now.

On other idea to handle missing translations, is to show instead of the key, the English translation in red.
So the user can make use of the existing translations and see what is missing.

@i-make-robots
Copy link
Contributor

If anything I wish the other language files were more like the english one. Scrolling forever is painful.
I completely agree that sorting by key should be a thing.
I would prefer to show the key name instead of the english value.

@peter-pri
Copy link
Contributor Author

OK, I see.
I translate some additional entries.
I don' t know why I didn't see them yesterday.

@i-make-robots i-make-robots merged commit e453a73 into MarginallyClever:master May 31, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants