-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support subprotocols derived from WebSocket #125
Open
mzapataj
wants to merge
4
commits into
Marfusios:master
Choose a base branch
from
mzapataj:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+44
−8
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
using System; | ||
|
||
// ReSharper disable once CheckNamespace | ||
namespace Websocket.Client.Models | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a breaking change, put it back or we will need to deploy it under version |
||
namespace Websocket.Client | ||
{ | ||
/// <summary> | ||
/// Info about happened reconnection | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,7 +10,6 @@ | |
using System.Threading.Tasks; | ||
using Websocket.Client.Exceptions; | ||
using Websocket.Client.Logging; | ||
using Websocket.Client.Models; | ||
using Websocket.Client.Threading; | ||
|
||
namespace Websocket.Client | ||
|
@@ -41,6 +40,34 @@ public partial class WebsocketClient : IWebsocketClient | |
private readonly Subject<ReconnectionInfo> _reconnectionSubject = new Subject<ReconnectionInfo>(); | ||
private readonly Subject<DisconnectionInfo> _disconnectedSubject = new Subject<DisconnectionInfo>(); | ||
|
||
|
||
/// <summary> | ||
/// | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Comments please |
||
/// </summary> | ||
/// <param name="clientFactory"></param> | ||
|
||
public WebsocketClient(Func<ClientWebSocket> clientFactory = null) | ||
: this(GetClientFactory(clientFactory)) | ||
{ | ||
} | ||
|
||
/// <summary> | ||
/// | ||
/// </summary> | ||
public WebsocketClient(Func<Uri, CancellationToken, Task<WebSocket>> connectionFactory = null) | ||
{ | ||
_connectionFactory = connectionFactory ?? (async (uri, token) => | ||
{ | ||
//var client = new ClientWebSocket | ||
//{ | ||
// Options = { KeepAliveInterval = new TimeSpan(0, 0, 5, 0) } | ||
//}; | ||
var client = new ClientWebSocket(); | ||
await client.ConnectAsync(uri, token).ConfigureAwait(false); | ||
return client; | ||
}); | ||
} | ||
|
||
/// <summary> | ||
/// A simple websocket client with built-in reconnection and error handling | ||
/// </summary> | ||
|
@@ -165,6 +192,9 @@ public bool IsReconnectionEnabled | |
/// <inheritdoc /> | ||
public ClientWebSocket NativeClient => GetSpecificOrThrow(_client); | ||
|
||
/// <inheritdoc /> | ||
public Predicate<string> IsSubprotocolMessage { get; set; } = null; | ||
|
||
/// <summary> | ||
/// Terminate the websocket connection and cleanup everything | ||
/// </summary> | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this used?