Fixes on boiling step function #172
Conversation
rhuanecc
commented
Feb 4, 2018
rhuanecc
commented
- Fixed hints on GUI. Now all 5 appear. Added more explanatory text.
- Fixed a bug when some hop times were left blank at boiling step configuration.
- Fixed the hop adding time. Number inserted represents the time before the end of the boiling process.
- Fixed the hop time not being checked when temperature dropped below setpoint.
Fixed typos and GUI hints on hop time alert - boiling step.
When hop times were left blank on boiling configuration, step timer didn't appear on GUI, neither the alert. Alert time also fixed to be shown the entered amount of minutes before the end of boiling process. Not after the boiling start.
Hop time was not being checked in case the temperature dropped below the setpoint, even when into the offset margin. Now it's being checked every iteration after the timer starts.
|
if you use => on line 205 can we use the first wort hop and late hop... :) |
|
can you help us with the cbpi-boil-hopdropper too? tks |
|
I’m not sure adding an equals accomplishes what you are hoping for. For first wort would occur at the end of the mash/sparge or when the boil step initiates. Late hop would occur in the chill/whirlpool step. Problem is not all brewers/recipe use them, so a custom step would be better for some users. Keeping the current steps generic encompasses more people’s procedures. Right now the hop alerts go off, as you wrote, when then the time is passed the time for the hop. I think it should happen when they are both equal but the results are the same. Great work on fixing the empty field bug! |
