Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename modules #375

Merged
merged 14 commits into from
Nov 19, 2024
Merged

Rename modules #375

merged 14 commits into from
Nov 19, 2024

Conversation

mschwoer
Copy link
Contributor

@mschwoer mschwoer commented Nov 18, 2024 •
edited
Loading

  • renaming all modules to follow python conventions
  • renumber gui pages
  • create dedicated dataset package
  • move load_data() to conftest.py

JuliaS92
JuliaS92 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@JuliaS92 JuliaS92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the tests run through

@mschwoer mschwoer merged commit 13b67bf into development Nov 19, 2024
5 checks passed
@mschwoer mschwoer deleted the rename_modules branch November 19, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliaS92 JuliaS92 JuliaS92 approved these changes

@boopthesnoot boopthesnoot Awaiting requested review from boopthesnoot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mschwoer @JuliaS92