simplify_analysis-III #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuliaS92
reviewed
Nov 7, 2024
|
|
||
| else: | ||
| st.info("Import Data first") | ||
| # TODO do we want to save statistical analysis to results page as well? |
There was a problem hiding this comment.
The answer was yes. Resolve and merge if this was implemented in the meantime.
JuliaS92
reviewed
Nov 7, 2024
| if "settings" in list(method_dict.keys()): | ||
| settings_dict = method_dict.get("settings") | ||
| if "settings" not in method_dict: | ||
| # TODO: is this check really required here? If so, refactor to be part of plotting/statistic_options |
There was a problem hiding this comment.
I am confused by this, too. Has this resolved in the meantime?
There was a problem hiding this comment.
yes, this logic is now explicit
JuliaS92
reviewed
Nov 7, 2024
| ) | ||
|
|
||
| if group != default_option: | ||
| unique_values = get_unique_values_from_column(column=group) | ||
| unique_values = dataset.metadata[group].unique().tolist() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplifies the Analysis and Results page.
Note that I also changed the behaviour: plots are only saved to the "results" page on request.