simplify_analysis-II #351
Merged
simplify_analysis-II #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boopthesnoot
approved these changes
Oct 18, 2024
JuliaS92
reviewed
Nov 7, 2024
| @@ -1,12 +1,12 @@ | |||
| import streamlit as st | |||
| from gui.utils.options import get_plotting_options, get_statistic_options | |||
There was a problem hiding this comment.
I get that we wanted to declutter the session state. How expensive is it to run these functions? Maybe we can at least restrict that to once per page reload, or cache the result.
There was a problem hiding this comment.
they will be removed in a later PR
JuliaS92
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplify option loading for analysis page