liniting_rule_E #350
Merged
liniting_rule_E #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschwoer
force-pushed
the
liniting_rule_E
branch
from
9b45dbf
to
190496d
Compare
JuliaS92
reviewed
Nov 7, 2024
| @@ -37,7 +37,7 @@ def save_plot_to_session_state(plot, method): | |||
|
|
|||
|
|
|||
| def display_df(df): | |||
There was a problem hiding this comment.
This should use pandas stylers, rather than changing the data, as this can become quite a lot to handle. Also not sure, why we need this.
JuliaS92
reviewed
Nov 7, 2024
| return result | ||
|
|
||
| return wrapper | ||
|
|
||
|
|
||
| def find_duplicates_in_list(l: list) -> list: | ||
| """Find duplicates in a list | ||
| def find_duplicates_in_list(input_list: list) -> list: |
There was a problem hiding this comment.
This function is only used once to assert index uniqueness, and should be replaced with https://pandas.pydata.org/docs/reference/api/pandas.Index.has_duplicates.html#pandas.Index.has_duplicates
JuliaS92
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes for linting rules E
get rid of the non-breaking spaces