Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liniting_rule_F #349

Merged
merged 5 commits into from
Nov 8, 2024
Merged

liniting_rule_F #349

merged 5 commits into from
Nov 8, 2024

Conversation

mschwoer
Copy link
Contributor

@mschwoer mschwoer commented Oct 18, 2024 •
edited
Loading

fixes for linting rule F

Base automatically changed from liniting_rule_B to development October 18, 2024 08:53
JuliaS92
JuliaS92 approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@JuliaS92 JuliaS92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I think we will need to put exact values on all the volcano tests, once we verified the functions.

@mschwoer mschwoer merged commit 758f873 into development Nov 8, 2024
5 checks passed
@mschwoer mschwoer deleted the liniting_rule_F branch November 8, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliaS92 JuliaS92 JuliaS92 approved these changes

@boopthesnoot boopthesnoot Awaiting requested review from boopthesnoot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mschwoer @JuliaS92