Decouple dataset from statistics #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
decouple-dataset-from-enrichment
to
development
September 20, 2024 13:27
# Conflicts: # alphastats/DataSet_Statistics.py # alphastats/gui/utils/overview_helper.py # alphastats/statistics/DifferentialExpressionAnalysis.py # tests/test_DataSet.py
JuliaS92
reviewed
Sep 24, 2024
| ).calculate() | ||
| return res, plot_list | ||
| # @ignore_warning(RuntimeWarning) | ||
| # def multicova_analysis( # TODO never used outside of tests .. how does this relate to multicova.py? |
There was a problem hiding this comment.
In MultiCovaAnalysis multicova.py is imported from the calculate function.
def calculate(self):
from alphastats.multicova import multicova
This is defenitely a feature we want in the tool, so it should remain active but we need a ticket for putting it in the interface.
There was a problem hiding this comment.
JuliaS92
reviewed
Sep 24, 2024
| @@ -386,7 +386,3 @@ def load_options(): | |||
| st.session_state[StateKeys.STATISTIC_OPTIONS] = statistic_options(st.session_state) | |||
| # TODO: Check if this should be reintroduced or removed | |||
| # st.session_state["interpretation_options"] = interpretation_options | |||
|
|
|||
|
|
|||
| def gui_multicova_analysis(): | |||
There was a problem hiding this comment.
Add big todo here instead of removing it.
There was a problem hiding this comment.
I think once the time comes, we will be able to reimplement this method :-D
JuliaS92
reviewed
Sep 24, 2024
| @@ -152,7 +175,7 @@ def _sam_calculate_fdr_line(self): | |||
| ) | |||
|
|
|||
| @lru_cache(maxsize=20) | |||
| def _sam(self): | |||
| def _sam(self): # TODO duplicated? | |||
There was a problem hiding this comment.
Only the last two lines differ from the function in DifferentialExpressionAnalysis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a huge one, but could not be separated in a sensible way..
check the individual commits for the line of reasoning (the bug in fc calculation in de72c6e is removed again later
I think now I see where this could be going: the
DataSetclass will contain the data (mat,metadata) and beside that be just a convenient interface for the frontend. It will offer all operations that can be done on the data (statistics, plots, preprocessing), but delegate the logic to dedicated classes. Two things are missing still:Plotsinit(i.e. the actual data loading) to another class (similar toStatistics, ..)