Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 1.5.0 #69

Merged
merged 99 commits into from
Dec 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
99 commits
Select commit Hold shift + click to select a range
4daeaa1
initial workflow setup
GeorgWa Nov 7, 2023
ff517b3
Merge branch 'development' into protein-processing
GeorgWa Nov 7, 2023
93f9b31
FIX custom decoy column name
GeorgWa Nov 7, 2023
b336c9f
FEAT automated protein FDR
GeorgWa Nov 8, 2023
0c43e31
FEAT library grouping option for benchmarking
GeorgWa Nov 8, 2023
909dd0a
Model speedup try
Nov 9, 2023
69a8f08
Added black linter to github actions
Nov 13, 2023
7efc1b3
FIX include d12
GeorgWa Nov 14, 2023
8d2ce06
FIX updated debugging notebook
GeorgWa Nov 14, 2023
6e494c1
FIX remove persistant elution profiles
GeorgWa Nov 14, 2023
80a7e09
Model speedup
Nov 14, 2023
4974898
FEAT dictless feature implementation
GeorgWa Nov 15, 2023
11c64cb
FIX updated grouping unit test
GeorgWa Nov 15, 2023
0e243e9
Merge pull request #57 from MannLabs/protein-processing
GeorgWa Nov 15, 2023
b21f4dc
Merge branch 'development' into remove-group-performance
GeorgWa Nov 15, 2023
d53c9bf
made metrics calculation optional
Nov 15, 2023
fcbe051
Merge pull request #59 from MannLabs/remove-group-performance
GeorgWa Nov 15, 2023
5fb4d4d
Merge pull request #56 from MannLabs/github-actions
GeorgWa Nov 15, 2023
1b8eb1e
CHORE Black init
GeorgWa Nov 15, 2023
930bad2
FEAT fdr model speedup
GeorgWa Nov 15, 2023
b8b170e
Apply Black formatting
invalid-email-address Nov 15, 2023
d7960c5
FIX updated testcase
GeorgWa Nov 15, 2023
9989bcf
Merge branch 'models-new' of github.com:MannLabs/alphadia into models…
GeorgWa Nov 15, 2023
2235a6c
FIX updated fdr test
GeorgWa Nov 15, 2023
651afdd
FIX updated fdr test
GeorgWa Nov 15, 2023
7c32431
Merge pull request #62 from MannLabs/models-new
GeorgWa Nov 15, 2023
f38ebdf
CHORE updated unit tests
GeorgWa Nov 15, 2023
9175c6e
Apply Black formatting
invalid-email-address Nov 15, 2023
1a35797
Merge pull request #63 from MannLabs/updated-tests
GeorgWa Nov 16, 2023
5d0455c
FEAT don't store library slice
GeorgWa Nov 17, 2023
a805783
FIX improved workflow hyperparameters
GeorgWa Nov 17, 2023
f771721
FEAT no fragment collection for decoys
GeorgWa Nov 18, 2023
0ed4e4c
FIX apply top_k_fragments on library
GeorgWa Nov 18, 2023
62f3318
Merge branch 'development' into dictless-features
GeorgWa Nov 18, 2023
48af34b
Apply Black formatting
invalid-email-address Nov 18, 2023
81c358f
black formatting
GeorgWa Nov 18, 2023
6823de7
Merge branch 'dictless-features' of github.com:MannLabs/alphadia into…
GeorgWa Nov 18, 2023
aa46171
Merge fixes
GeorgWa Nov 18, 2023
0fa0f38
Apply Black formatting
invalid-email-address Nov 18, 2023
2d15ca6
FEAT autoamtic FDR testing
GeorgWa Nov 19, 2023
ea38cb6
Apply Black formatting
invalid-email-address Nov 19, 2023
bdc817e
FIX include default parameters in -h
GeorgWa Nov 19, 2023
20ec754
Merge branch 'fdr-test' of github.com:MannLabs/alphadia into fdr-test
GeorgWa Nov 19, 2023
411caf3
Apply Black formatting
invalid-email-address Nov 19, 2023
dad4e35
updated fdr hyperparameters
GeorgWa Nov 20, 2023
4cd70b7
Merge branch 'dictless-features' of github.com:MannLabs/alphadia into…
GeorgWa Nov 20, 2023
897fca6
updated FDR parameters
GeorgWa Nov 20, 2023
afee0cf
introducing legacy classifier again
GeorgWa Nov 20, 2023
959244d
Merge branch 'fdr-test' of github.com:MannLabs/alphadia into fdr-test
GeorgWa Nov 20, 2023
061a415
Apply Black formatting
invalid-email-address Nov 20, 2023
ee0b633
FIX epochs for unit test
GeorgWa Nov 20, 2023
bb4136e
Merge branch 'fdr-test' of github.com:MannLabs/alphadia into fdr-test
GeorgWa Nov 20, 2023
2f4224c
Merge pull request #65 from MannLabs/fdr-test
GeorgWa Nov 20, 2023
368cdb3
Merge branch 'development' into dictless-features
GeorgWa Nov 20, 2023
e2b4b32
FIX remove patience parameter
GeorgWa Nov 20, 2023
9e5f0b8
Fix use old lr
GeorgWa Nov 20, 2023
f189076
Merge pull request #64 from MannLabs/dictless-features
GeorgWa Nov 20, 2023
70a4d71
CHORE improved error message for grouping
GeorgWa Nov 20, 2023
6074394
FIX empty stats df for failed searches
GeorgWa Nov 20, 2023
49c582b
allow for psm.tsv failure
GeorgWa Nov 20, 2023
fe22b74
Resolve conflicts by accepting changes from development branch
Nov 21, 2023
a66311f
added model choice as parameter to fdr_test.py
Nov 21, 2023
550681b
CHORE lib handlin for mbr
GeorgWa Nov 21, 2023
7118ef9
FEAT automated MBR lib generation
GeorgWa Nov 22, 2023
c26166d
FIX make sure column is string
GeorgWa Nov 22, 2023
fc39f77
fix typo
GeorgWa Nov 22, 2023
8abdb30
Added fdr and auc metrics calculation
Nov 22, 2023
bc97e8c
FIX config updatd default
GeorgWa Nov 23, 2023
548c916
FEAT move mobility features to separate function
GeorgWa Nov 24, 2023
6f8e778
improved candidate scoring
GeorgWa Nov 25, 2023
c456994
FEAT exporting fragment quantities
GeorgWa Nov 27, 2023
df88344
TEST skip fft
GeorgWa Nov 27, 2023
caf11df
FEAT SearchPlanOutput workflow
GeorgWa Nov 29, 2023
285273f
added config parameters
GeorgWa Nov 29, 2023
806290c
FEAT outputtransform unit test
GeorgWa Nov 30, 2023
a6d1da9
Apply Black formatting
invalid-email-address Dec 1, 2023
ba56881
Merge pull request #67 from MannLabs/output-handling
GeorgWa Dec 1, 2023
d9ce1d7
CHORE updated requirements
GeorgWa Dec 1, 2023
befd4d6
FIX pytorch conversion
GeorgWa Dec 1, 2023
9cbc121
FEAT use new batching by default
GeorgWa Dec 1, 2023
3633e38
Merge branch 'development' into models
GeorgWa Dec 1, 2023
0c861a8
Merge pull request #66 from MannLabs/models
GeorgWa Dec 1, 2023
a57fba9
FEAT use fragment correlation
GeorgWa Dec 1, 2023
ffb8f01
Merge branch 'development' into workflow-optim
GeorgWa Dec 1, 2023
2f019f1
CHORE test hyperparameters
GeorgWa Dec 1, 2023
7a4272e
Merge pull request #68 from MannLabs/workflow-optim
GeorgWa Dec 1, 2023
24ac3cf
FIX 1% recalibration target
GeorgWa Dec 2, 2023
66b30d6
Merge branch 'development' of github.com:MannLabs/alphadia into devel…
GeorgWa Dec 2, 2023
1bb4113
readme
GeorgWa Dec 5, 2023
45dbad6
readme fix
GeorgWa Dec 5, 2023
4645912
Bump version: 1.4.0 → 1.5.0
GeorgWa Dec 5, 2023
08f6f2e
Merge branch 'main' into development
GeorgWa Dec 6, 2023
f13fc0a
FIX merge error
GeorgWa Dec 6, 2023
4ec03be
FIX merge errors
GeorgWa Dec 6, 2023
839eacd
FIX timstof segfault
GeorgWa Dec 6, 2023
a61c0df
FIX sequence output
GeorgWa Dec 7, 2023
3c9e34b
FEAT traceback during output building
GeorgWa Dec 10, 2023
8ec6634
FIX set directLFQ config
GeorgWa Dec 10, 2023
73caf3b
FEAT environment logging
GeorgWa Dec 10, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions .github/workflows/black.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
name: Black linter

on:
pull_request:
paths:
- '**.py'

jobs:
lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
ref: ${{ github.head_ref }}
token: ${{ secrets.GITHUB_TOKEN }}

- name: Install Black
run: pip install 'black[jupyter]==23.11.0'

- name: Run Black
id: black_check
run: |
black --check --verbose . || echo "CHANGES_NEEDED=true" >> $GITHUB_ENV
continue-on-error: true

- name: Apply Black reformatting
if: env.CHANGES_NEEDED=='true'
run: |
black .
git config --global user.name 'github-actions'
git config --global user.email '[email protected]'
git add -A
git diff --quiet && git diff --staged --quiet || (git commit -m "Apply Black formatting" && git push)
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2 changes: 1 addition & 1 deletion alphadia/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@


__project__ = "alphadia"
__version__ = "1.4.0"
__version__ = "1.5.0"
__license__ = "Apache"
__description__ = "An open-source Python package of the AlphaPept ecosystem"
__author__ = "Mann Labs"
Expand Down
20 changes: 19 additions & 1 deletion alphadia/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,23 @@
from alphadia.workflow import reporting
from alphadia import utils

from alphabase.constants import modification

modification.add_new_modifications(
{
"Dimethyl:d12@Protein N-term": {"composition": "H(-2)2H(8)13C(2)"},
"Dimethyl:d12@Any N-term": {
"composition": "H(-2)2H(8)13C(2)",
},
"Dimethyl:d12@R": {
"composition": "H(-2)2H(8)13C(2)",
},
"Dimethyl:d12@K": {
"composition": "H(-2)2H(8)13C(2)",
},
}
)

# alpha family imports

# third party imports
Expand Down Expand Up @@ -101,6 +118,7 @@ def gui():
"--config-update",
help="Dict which will be used to update the default config.",
type=str,
default={},
)
@click.option(
"--neptune-token",
Expand All @@ -124,7 +142,7 @@ def extract(**kwargs):
kwargs["neptune_tag"] = list(kwargs["neptune_tag"])

# load config file if specified
config_update = None
config_update = {}
if kwargs["config"] is not None:
with open(kwargs["config"], "r") as f:
config_update = yaml.safe_load(f)
Expand Down
8 changes: 5 additions & 3 deletions alphadia/fdr.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ def perform_fdr(
competetive: bool = False,
group_channels: bool = True,
figure_path: Optional[str] = None,
neptune_run=None,
):
"""Performs FDR calculation on a dataframe of PSMs

Expand Down Expand Up @@ -123,7 +124,7 @@ def perform_fdr(
classifier,
psm_df["qval"],
figure_path=figure_path,
# neptune_run=neptune_run
neptune_run=neptune_run,
)

return psm_df
Expand Down Expand Up @@ -339,6 +340,7 @@ def plot_fdr(
ax[0].set_ylabel("true positive rate")
ax[0].legend()

ax[1].set_xlim(0, 1)
ax[1].hist(
np.concatenate([y_test_proba[y_test == 0], y_train_proba[y_train == 0]]),
bins=50,
Expand Down Expand Up @@ -376,7 +378,7 @@ def plot_fdr(
if figure_path is not None:
fig.savefig(os.path.join(figure_path, "fdr.pdf"))

# if neptune_run is not None:
# neptune_run['eval/fdr'].log(fig)
if neptune_run is not None:
neptune_run["eval/fdr"].log(fig)

plt.close()
Loading
Loading