Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes 2 #391

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Misc fixes 2 #391

wants to merge 2 commits into from

Conversation

mschwoer
Copy link
Collaborator

  • unify import of njit
  • fix typo in config (breaking ;-))

Copy link
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -53,7 +53,7 @@ library_prediction:

# define custom alphabase modifications not part of unimod or alphabase
# also used for decoy channels
custom_modififcations:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s breaking in theory :D alphabase can’t use the custom mods with multiprocessing yet. So it’s not being used (yet)

@@ -13,7 +6,7 @@
from alphadia import utils


@alphatims.utils.njit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check the alphatims function? I wonder why I did this in the first place ( I already see some weird numbs thing happening :D )

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the @alphatims.utils.njit decorator

def njit(_func=None, *args, **kwargs):
    import numba
    return numba.njit(_func, *args, **kwargs)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants