Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor readers vi #248

Open
wants to merge 15 commits into
base: refactor_readers_V
Choose a base branch
from
Open

Refactor readers vi #248

wants to merge 15 commits into from
+85 −75

Commits on Nov 20, 2024

  1. refactor mod_seq_column logic

    @mschwoer
    mschwoer committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    bae93fb View commit details
    Browse the repository at this point in the history

  2. add docstrings

    @mschwoer
    mschwoer committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    8f5cb80 View commit details
    Browse the repository at this point in the history

  3. fix tests

    @mschwoer
    mschwoer committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    e28463b View commit details
    Browse the repository at this point in the history

  4. fix identation in MAxQuantReader._load_file

    @mschwoer
    mschwoer committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    2e10f33 View commit details
    Browse the repository at this point in the history

  5. separate file loading and preprocessing

    @mschwoer
    mschwoer committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    09c382a View commit details
    Browse the repository at this point in the history

  6. remove obsolete calls to _get_mod_seq_column

    @mschwoer
    mschwoer committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    ce94f48 View commit details
    Browse the repository at this point in the history

  7. remove obsolete calls to _get_mod_seq_column

    @mschwoer
    mschwoer committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    4c38d2f View commit details
    Browse the repository at this point in the history

  8. provide default implementation for _load_file

    @mschwoer
    mschwoer committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    76a3d30 View commit details
    Browse the repository at this point in the history

  9. make DiannReader a MaxQuantReader

    @mschwoer
    mschwoer committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    d933f63 View commit details
    Browse the repository at this point in the history

  10. Revert "make DiannReader a MaxQuantReader" 

    This reverts commit d933f63.
    @mschwoer
    mschwoer committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    067d324 View commit details
    Browse the repository at this point in the history

  11. Revert "provide default implementation for _load_file" 

    This reverts commit 76a3d30.
    @mschwoer
    mschwoer committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    74263bd View commit details
    Browse the repository at this point in the history

  12. Revert "remove obsolete calls to _get_mod_seq_column" 

    This reverts commit 4c38d2f.
    @mschwoer
    mschwoer committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    a57285f View commit details
    Browse the repository at this point in the history

  13. Revert "remove obsolete calls to _get_mod_seq_column" 

    This reverts commit ce94f48.
    @mschwoer
    mschwoer committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    a6f7978 View commit details
    Browse the repository at this point in the history

  14. Revert "separate file loading and preprocessing" 

    This reverts commit 09c382a.
    @mschwoer
    mschwoer committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    11bf2ff View commit details
    Browse the repository at this point in the history

  15. fix tests

    @mschwoer
    mschwoer committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    23030f0 View commit details
    Browse the repository at this point in the history