Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Prism rendering #4003

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix Prism rendering #4003

wants to merge 5 commits into from

Conversation

ra1u
Copy link

@ra1u ra1u commented Nov 9, 2024

Fixes Prism, that shows cube of size 2.

behackl
behackl requested changes Nov 24, 2024
View reviewed changes
Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thanks for your contribution!

I have a slightly different suggestion for a more sustainable fix that takes care of the situation for all subclasses of Cube. Please take a look!

manim/mobject/three_d/three_dimensions.py Outdated Show resolved Hide resolved
@behackl behackl added the enhancement Additions and improvements in general label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behackl behackl behackl approved these changes

Assignees
No one assigned
Labels
enhancement Additions and improvements in general
Projects
Dev Board
Status: 👍 To be merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ra1u @behackl