-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Elevenlabs service #83
Add Elevenlabs service #83
Conversation
@osolmaz , have you had a chance to review the PR? If any changes, let me know... |
Thank you! I did some minor refactors. I notice some issues that might be related to the library itself, like cached audio files are not used and are regenerated every run. This is not good since the API is not free. Will try to resolve those now. In the meanwhile, can you add documentation? Like I saw this, but there was no such section on that page:
|
@mohit2152sharma I improved caching behavior and enabled transcription with Whisper by default. This is necessary to use bookmarks. Can you check whether Elevenlabs API returns word boundaries (timestamps for beginning of each word in the audio)? I looked briefly and couldn't see it, but I feel like it might be hidden somewhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added remaining tasks to your first post, also see my comments.
@osolmaz , I added the documentation. For the bookmark part, it wasn't working for me until i changed Regarding caching I assumed that it was a bug as it wasn't respecting the |
I just ran the bookmark example using the default voice, the quality out of the box is insane. You could get to something very reasonable with a little tweaking. BookmarkExample.mp4 |
Btw |
Added support for elevenlabs, with better parameter support. Have the option to select voice based on
voice_name
orvoice_id
. Also change the settings of voice usingvoice_settings
parameter.Remaining tasks:
ElevenLabsService
to https://github.com/ManimCommunity/manim-voiceover/blob/main/docs/source/services.rst