Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement on Github actions #628

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Improvement on Github actions #628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72c1e94
run tests only on PR and push on master
mihaimoiseanu Feb 19, 2024
2d304a8
disable pipelines for php<7.2
mihaimoiseanu Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@ on:
branches:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also disable pipeline for version <= 7.2

# push on master branch
- master
# push on a feature branch
- feature/*
# push on a bugfix branch
- bugfix/*
pull_request:
branches: [ master ]

Expand All @@ -20,7 +16,7 @@ jobs:
strategy:
fail-fast: false
matrix:
php-version: ["5.6", "7.1", "7.2", "7.3", "7.4", "8.0"]
php-version: ["7.3", "7.4", "8.0"]
os: [ubuntu-latest]
experimental: [false]
composer-options: ['']
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Use php 7.1
- name: Use php 7.3
uses: shivammathur/setup-php@v2
with:
php-version: 7.1
php-version: 7.3
- name: Validate composer.json
run: composer validate
- name: Cache module
Expand Down
Loading