[WIP] convert console_supported? to supports?

[kbrock]

part of ManageIQ/manageiq#21990

I could have sworn that there was a @record.supports?(@feature) in a button, but couldn't find something immediately obvious

[miq-bot]

Checked commit kbrock@c7e7637 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
2 files checked, 1 offense detected

app/helpers/application_helper/button/vm_html5_console.rb

• ❗ - Line 5, Col 5 - Rails/HelperInstanceVariable - Do not use instance variables in helpers.

[kbrock]

Not sure if the cop is valid, but ignoring as it is basically what was there before

[agrare]

Wow is this really it?

[agrare]

I think we can probably rewrite https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/helpers/application_helper/button/vm_vmrc_console.rb and https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/helpers/application_helper/button/vm_native_console.rb to be more generic (aka drop the vendor == vmware stuff)

[kbrock]

Ok, I read change them to just use "supports?"

Do we have an opinion on whether to change the supports to add some of the other "this vm is on" kind of logic that we are putting in the validates?

Are we thinking we should drop that validates method all together? (I'm suggesting it)

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

[miq-bot]

This pull request has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.