Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] convert console_supported? to supports #446

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Mar 8, 2023

part of ManageIQ/manageiq#21990

I also got distracted and removed the unsupported_reason_add method. we can remove this second commit if we feel it is too much.

@kbrock
Copy link
Member Author

kbrock commented Mar 8, 2023

udpate:

  • fixed extra paren in code (ugh)

@kbrock
Copy link
Member Author

kbrock commented Mar 8, 2023

  • fixed paren
  • fixed cop unless/else
  • fixed typo on archived:
    (3 different pushes)

@miq-bot
Copy link
Member

miq-bot commented Jun 12, 2023

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@miq-bot miq-bot closed this Sep 18, 2023
@miq-bot
Copy link
Member

miq-bot commented Sep 18, 2023

This pull request has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@kbrock kbrock reopened this Oct 3, 2023
@kbrock kbrock removed the stale label Oct 3, 2023
@miq-bot miq-bot added the stale label Jan 8, 2024
@miq-bot
Copy link
Member

miq-bot commented Jan 8, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@kbrock kbrock requested a review from Fryguy as a code owner March 1, 2024 01:23
@kbrock kbrock changed the title convert console_supported? to supports [WIP] convert console_supported? to supports Mar 1, 2024
@kbrock kbrock added wip and removed unmergeable labels Mar 1, 2024
@miq-bot
Copy link
Member

miq-bot commented Mar 1, 2024

Checked commit kbrock@95a9ae6 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@miq-bot
Copy link
Member

miq-bot commented Jun 3, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@miq-bot
Copy link
Member

miq-bot commented Jul 2, 2024

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Oct 7, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants