6 -select time period on map- Delnia #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add some data
mferryRV
approved these changes
Oct 9, 2023
| import React, { useState, useEffect } from "react"; | ||
| import DualRangeSlider from "./DualRangeSlider"; | ||
|
|
||
| const RhythmsWithSlider = ({ rhythms }) => { |
There was a problem hiding this comment.
This is a good illustration of how the component will operate using state. When it's integrated, we should look to move this state into the main page.
| import DualRangeSlider from "./DualRangeSlider"; | ||
|
|
||
| const RhythmsWithSlider = ({ rhythms }) => { | ||
| const [selectedRange, setSelectedRange] = useState([1400, 2023]); |
There was a problem hiding this comment.
For long-term projects, it's better to use something like Date.now() and get the year rather than hard-coding, but good illustration of the max/min
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naming Rules
Name your PR like this: ISSUENUMBER-TITLE-YOURNAME
Description
The functionality (for now) is selecting a time period, by decade, within 1400 to present day with a slider.
#6
Make sure you include the issue number with a hash sign # so Github can link this PR to the right issue, like this:
Fixes
Checklist: