MAKAIRA-4359 Apply feedback from PR

MakairaIO · Apr 8, 2024 · 80e1735 · 80e1735
1 parent f665527
commit 80e1735
Showing 1 changed file with 1 addition and 14 deletions.
diff --git a/src/AbstractQuery.php b/src/AbstractQuery.php
@@ -69,7 +69,7 @@ public function setConstraint($constraint, $value)
     public function verify()
     {
         foreach ($this->getMandatoryConstraints() as $key => $label) {
-            if (!$this->isConstraintExists($key)) {
+            if (empty($this->constraints[$key])) {
                 throw new DomainException(sprintf('Missing mandatory %s constraint.', $label));
             }
         }
@@ -116,17 +116,4 @@ public static function createFromRequest($data)
             ->verify()
             ->filterConstraints();
     }
-
-    private function isConstraintExists($key)
-    {
-        if (!isset($this->constraints[$key])) {
-            return false;
-        }
-
-        if ('' === $this->constraints[$key]) {
-            return false;
-        }
-
-        return true;
-    }
 }