To modify the query and response to Makaira API, with DI. #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmloberon
force-pushed
the
feature/more_events_to_modifi_query_respone
branch
2 times, most recently
from
6353491 to
055aa1f
Compare
tmloberon
force-pushed
the
feature/more_events_to_modifi_query_respone
branch
from
055aa1f to
90a94a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some events were added to process the request. With the Symfony DI.
So you don't have to activate another OXID module.
There are the Event:
makaira.response.autosuggester(\Makaira\Connect\Event\AutoSuggesterResponseEvent::NAME)makaira.response.search(\Makaira\Connect\Event\SearchResponseEvent::NAME)makaira.request.modifier.query.search(\Makaira\Connect\Event\ModifierQueryRequestEvent::NAME_SEARCH)makaira.request.modifier.query.autosuggester(\Makaira\Connect\Event\ModifierQueryRequestEvent::NAME_AUTOSUGGESTER)With UnitTests
I have not tested it on version 3x, because the dispatch function changes and I have not installed a new OXID.