ci: improve android ci (#99)

.github/workflows/android ci.yml

@@ -0,0 +1,26 @@
+name: Android CI
+
+on: [push, pull_request]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+
+      - name: Set up JDK
+        uses: actions/setup-java@v3
+        with:
+          java-version: 17
+          distribution: temurin
+
+      - name: code quality with detekt
+        run: ./gradlew detekt
+
+#      - name: test
+#        run: ./gradlew test
+#
+#      - name: build app
+#        run: ./gradlew build

app/build.gradle

@@ -129,6 +129,16 @@ dependencies {
 
 apply plugin: "org.jlleitschuh.gradle.ktlint"
 
+detekt {
+    buildUponDefaultConfig = true
+    allRules = false
+    baseline = file("detekt-baseline.xml")
+}
+
+tasks.withType(Detekt).configureEach {
+    jvmTarget = "1.8"
+}
+
 tasks.register('detektFormat', Detekt) {
     description = "Runs autocorrect enabled detekt build."
     source = files("src/main/java")

app/src/main/java/education/mahmoud/quranyapp/feature/home_Activity/HomeActivity.kt

@@ -191,9 +191,9 @@ class HomeActivity : AppCompatActivity() {
     }
 
     override fun onRequestPermissionsResult(
-      requestCode: Int,
-      permissions: Array<String>,
-      grantResults: IntArray,
+        requestCode: Int,
+        permissions: Array<String>,
+        grantResults: IntArray,
     ) {
         super.onRequestPermissionsResult(requestCode, permissions, grantResults)
         if (requestCode == RC_STORAGE && grantResults[0] == PackageManager.PERMISSION_GRANTED) {

app/src/main/java/education/mahmoud/quranyapp/feature/read_log/ReadLogFragment.kt

@@ -23,7 +23,7 @@ class ReadLogFragment : DataLoadingBaseFragment() {
     private val quranRepository: QuranRepository by inject()
     private var logAdapter: ReadLogAdapter = ReadLogAdapter()
 
-    private val binding by viewBinding (FragmentReadLogBinding::bind )
+    private val binding by viewBinding(FragmentReadLogBinding::bind)
 
     override fun onCreateView(
         inflater: LayoutInflater,
@@ -62,7 +62,6 @@ class ReadLogFragment : DataLoadingBaseFragment() {
                 showMessage(getString(R.string.msg_deleted))
             }
         }).attachToRecyclerView(rvReadLog)
-
       } }
 
     private fun showMessage(message: String) {

app/src/main/java/education/mahmoud/quranyapp/feature/setting/SettingActivity.kt

@@ -22,7 +22,6 @@ class SettingActivity : AppCompatActivity() {
 
     private val binding by viewBinding(ActivitySettingBinding::inflate)
 
-
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
         setContentView(binding.root)

app/src/main/java/education/mahmoud/quranyapp/feature/showSuraAyas/PageAdapter.kt

@@ -19,8 +19,8 @@ class PageAdapter(
         val oldSize = list.size
         list.clear()
         list.addAll(newList)
-        notifyItemRangeRemoved(0 , oldSize)
-        notifyItemRangeInserted(0,newList.size)
+        notifyItemRangeRemoved(0, oldSize)
+        notifyItemRangeInserted(0, newList.size)
     }
 
     override fun onCreateViewHolder(viewGroup: ViewGroup, i: Int): PageViewHolder {
@@ -41,8 +41,6 @@ class PageAdapter(
           holder.topLinear?.visibility = vis*/
     }
 
-
-
     override fun getItemCount(): Int {
         return list.size
     }

app/src/main/java/education/mahmoud/quranyapp/feature/showSuraAyas/PageViewHolder.kt

@@ -7,7 +7,7 @@ import androidx.recyclerview.widget.RecyclerView
 import education.mahmoud.quranyapp.databinding.PageItemBinding
 import education.mahmoud.quranyapp.utils.Util
 
-class PageViewHolder(private val binding:PageItemBinding, iBookmark: PageAdapter.IBookmark?):RecyclerView.ViewHolder(binding.root) {
+class PageViewHolder(private val binding: PageItemBinding, iBookmark: PageAdapter.IBookmark?) : RecyclerView.ViewHolder(binding.root) {
 
     // defined here to not be created with each bind call.
     init {
@@ -36,4 +36,4 @@ class PageViewHolder(private val binding:PageItemBinding, iBookmark: PageAdapter
             binding.tvAyahs.justificationMode = LineBreaker.JUSTIFICATION_MODE_INTER_WORD
         }
     }
-}
+}

app/src/main/java/education/mahmoud/quranyapp/feature/show_sura_list/SuraListFragment.kt

@@ -30,7 +30,7 @@ class SuraListFragment : Fragment(R.layout.fragment_sura_list) {
     val bg = CompositeDisposable()
     private lateinit var screen: RecyclerViewSkeletonScreen
 
-    private val binding by viewBinding (FragmentSuraListBinding::bind )
+    private val binding by viewBinding(FragmentSuraListBinding::bind)
 
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         super.onViewCreated(view, savedInstanceState)

app/src/main/java/education/mahmoud/quranyapp/utils/Extensions.kt

@@ -19,9 +19,9 @@ fun Int.getSuraNameFromIndex(): String {
     return Data.SURA_NAMES[this - 1].orEmpty()
 }
 
-
 inline fun <T : ViewBinding> AppCompatActivity.viewBinding(
-    crossinline bindingInflater: (LayoutInflater) -> T) =
+    crossinline bindingInflater: (LayoutInflater) -> T
+) =
     lazy(LazyThreadSafetyMode.NONE) {
         bindingInflater.invoke(layoutInflater)
     }