-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed wide image on shorts #22
base: main
Are you sure you want to change the base?
Conversation
please rebase, also remove |
9ffd275
to
658b0c6
Compare
rebased and done with everything, now it's working with all of the shorts thumbnails on youtube |
Fixed that issue. The only other issue I still get is when sometimes mrbeast is cut out of the thumbnail, or we can only see his hands. For example (at the right bottom corner): |
This most likely occurs when the image is flipped, although there are some images that have MrBeast on the right by default. We could hardcode a list of images for the shorts thumbnails, but that goes against my design principles of making this add-on easy to port and modify. Thank you for your contribution. I won't merge it now, but I'll keep looking into a solution for these problems. |
Would a viable answer be to have the image element only be the same width as the short thumbnail element, also reducing the height? It'd make him very small but it's one solution? |
When the extension adds MrBeast to a short's thumbnail, it's way too wide:
I tried to change the styling of the MrBeast image on the short thumbnail, and found the (I hope) perfect settings for it:
which turned the thumbnail to look now like this:
which is way better then before. I modified the code so now it will show as this on shorts, and the normal settings on "normal" sized thumbnails.