Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wide image on shorts #22

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed wide image on shorts #22

wants to merge 2 commits into from

Conversation

itsrn
Copy link

@itsrn itsrn commented Jul 11, 2023

When the extension adds MrBeast to a short's thumbnail, it's way too wide:
image
I tried to change the styling of the MrBeast image on the short thumbnail, and found the (I hope) perfect settings for it:

top: 123px;
left: -3px;
width: 160%;
height: 50%;
z-index: 0;

which turned the thumbnail to look now like this:
image
which is way better then before. I modified the code so now it will show as this on shorts, and the normal settings on "normal" sized thumbnails.

@itsrn itsrn changed the title Fixed wide img for shorts Fixed wide image on shorts Jul 11, 2023
@ryantanrk
Copy link
Contributor

please rebase, also remove .ytd-rich-grid-slim-media from elementQuery on line 28 for it to show up on the home page

@itsrn itsrn closed this Jul 20, 2023
@itsrn itsrn force-pushed the main branch 2 times, most recently from 9ffd275 to 658b0c6 Compare July 20, 2023 09:03
@itsrn itsrn reopened this Jul 20, 2023
@itsrn
Copy link
Author

itsrn commented Jul 20, 2023

rebased and done with everything, now it's working with all of the shorts thumbnails on youtube

@MagicJinn
Copy link
Owner

I'm having an issue where MrBeast is not on the bottom of the image.
image

@itsrn
Copy link
Author

itsrn commented Jul 20, 2023

Fixed that issue. The only other issue I still get is when sometimes mrbeast is cut out of the thumbnail, or we can only see his hands. For example (at the right bottom corner):
image
I found it currently only with this image:
https://github.com/MagicJinn/MrBeastify-Youtube/blob/main/images/10.png

@MagicJinn
Copy link
Owner

This most likely occurs when the image is flipped, although there are some images that have MrBeast on the right by default. We could hardcode a list of images for the shorts thumbnails, but that goes against my design principles of making this add-on easy to port and modify. Thank you for your contribution. I won't merge it now, but I'll keep looking into a solution for these problems.

@redd-rl
Copy link

redd-rl commented Jul 21, 2023

Would a viable answer be to have the image element only be the same width as the short thumbnail element, also reducing the height? It'd make him very small but it's one solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants