Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix some typos #337

Merged
merged 1 commit into from
Dec 23, 2024
Merged

style: fix some typos #337

merged 1 commit into from
Dec 23, 2024

Conversation

mikavilpas
Copy link
Contributor

I found these using https://github.com/crate-ci/typos while I was looking at some implementation details. I think it's a quite safe change as long as you think it's worth including.

@MagicDuck
Copy link
Owner

Neat! Thanks for those! 😄
Just need to update some test snapshots. You can do that with:
make prepare
make test update_screenshots=true

see https://github.com/MagicDuck/grug-far.nvim/blob/main/CONTRIBUTING.md

@mikavilpas mikavilpas force-pushed the typos branch 2 times, most recently from 48dbb26 to 26b784b Compare December 23, 2024 17:02
@mikavilpas
Copy link
Contributor Author

Awesome 👍🏻

I noticed the test snapshots failed on my system because Neovim wants to use Finnish (the $LANG environment variable is set to "fi_FI.UTF-8"). It worked on my system, but when I tried to fix this in the test environment it looks like the language cannot be set there.

@@ -1,6 +1,8 @@
-- Add current directory to 'runtimepath' to be able to use 'lua' files
vim.cmd([[let &rtp.=','.getcwd()]])

vim.cmd('language en_US')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try this instead:
language en_US.UTF-8

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm looks like things work on my end now, but CI disagrees

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll see if there's a better way to configure my system...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, should be fixed now !

@MagicDuck
Copy link
Owner

Are you on nvim 0.10.1? Usually the attr cell difference is caused by different nvim version.

@mikavilpas
Copy link
Contributor Author

I'm on NVIM v0.11.0-dev-1397+gfd05c7f19d (built from source). I'll try to rebuild the snapshots with that version of neovim.

I set my environment variable to en_US now, let's see if I can fix this.

@MagicDuck
Copy link
Owner

nice! Thanks again for your contribution! 😄

@MagicDuck MagicDuck merged commit c88435b into MagicDuck:main Dec 23, 2024
5 checks passed
@mikavilpas mikavilpas deleted the typos branch December 23, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants